github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-03 03:53:37 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

platform/x86/intel/pmt: re-order trigger logic

Browse Source 
Setting the clear bit or checking the complete bit before checking to
see if crashlog is disabled seems incorrect.

Check disable before accessing any other bits.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Link: https://lore.kernel.org/r/20250713172943.7335-8-michael.j.ruhl@intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
This commit is contained in:
Michael J. Ruhl 2025-07-13 13:29:37 -04:00 committed by Ilpo Järvinen
parent 4f8fa22d10
commit 147c18d8ef
No known key found for this signature in database
GPG Key ID: 59AC4F6153E5CE31
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/platform/x86/intel/pmt/crashlog.c
View File

@ -193,6 +193,10 @@ trigger_store(struct device *dev, struct device_attribute *attr,
guard(mutex)(&entry->control_mutex);
/* if device is currently disabled, return busy */
if (pmt_crashlog_disabled(&entry->entry))
return -EBUSY;
if (!trigger) {
pmt_crashlog_set_clear(&entry->entry);
return count;
@ -202,10 +206,6 @@ trigger_store(struct device *dev, struct device_attribute *attr,
if (pmt_crashlog_complete(&entry->entry))
return -EEXIST;
/* if device is currently disabled, return busy */
if (pmt_crashlog_disabled(&entry->entry))
return -EBUSY;
pmt_crashlog_set_execute(&entry->entry);
return count;