github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 09:36:22 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

selftests/mm: ksm-functional-tests: fix partial write handling

Browse Source 
Update write() checks to properly detect and handle partial writes.

Previously, the write() calls used <= 0 to detect failure.  This condition
is never true for partial writes (ret > 0 but ret < len), so partial
writes were silently treated as success.

Fix this by verifying that write() returns the full expected length and
treating any mismatch as failure.

Link: https://lore.kernel.org/20260504081638.683223-1-agarwal.vineet2006@gmail.com
Signed-off-by: Vineet Agarwal <agarwal.vineet2006@gmail.com>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Cc: Liam Howlett <liam@infradead.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Vineet Agarwal 2026-05-04 13:43:13 +05:30 committed by Andrew Morton
parent 8e0c2085c9
commit 13f263b60f
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tools/testing/selftests/mm/ksm_functional_tests.c
View File

@ -498,6 +498,7 @@ static void test_prctl_fork(void)
static int start_ksmd_and_set_frequency(char *pages_to_scan, char *sleep_ms)
{
int ksm_fd;
size_t len;
ksm_fd = open("/sys/kernel/mm/ksm/run", O_RDWR);
if (ksm_fd < 0)
@ -506,11 +507,13 @@ static int start_ksmd_and_set_frequency(char *pages_to_scan, char *sleep_ms)
if (write(ksm_fd, "1", 1) != 1)
return -errno;
if (write(pages_to_scan_fd, pages_to_scan, strlen(pages_to_scan)) <= 0)
return -errno;
len = strlen(pages_to_scan);
if (write(pages_to_scan_fd, pages_to_scan, len) != len)
return -1;
if (write(sleep_millisecs_fd, sleep_ms, strlen(sleep_ms)) <= 0)
return -errno;
len = strlen(sleep_ms);
if (write(sleep_millisecs_fd, sleep_ms, len) != len)
return -1;
return 0;
}
@ -526,11 +529,11 @@ static int stop_ksmd_and_restore_frequency(void)
if (write(ksm_fd, "2", 1) != 1)
return -errno;
if (write(pages_to_scan_fd, "100", 3) <= 0)
return -errno;
if (write(pages_to_scan_fd, "100", 3) != 3)
return -1;
if (write(sleep_millisecs_fd, "20", 2) <= 0)
return -errno;
if (write(sleep_millisecs_fd, "20", 2) != 2)
return -1;
return 0;
}