github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-06 21:58:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: bridge: introduce a bridge destination type

Browse Source 
Add an opaque destination type and helpers for representing bridge port
destinations. Using a separate structure makes raw pointer assignments and
comparisons fail at build time while marking its value member __private
makes sparse warn about accesses that bypass the helpers.

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://patch.msgid.link/20260930071411.2786201-2-razor@blackwall.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Nikolay Aleksandrov 2026-09-30 10:14:00 +03:00 committed by Jakub Kicinski
parent 071876fd50
commit 13bb47965e
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
net/bridge/br_private.h
View File

@ -306,6 +306,10 @@ struct net_bridge_fdb_key {
u16 vlan_id;
};
struct net_bridge_dst {
unsigned long __private value;
};
struct net_bridge_fdb_entry {
struct rhash_head rhnode;
struct net_bridge_port *dst;
@ -670,6 +674,40 @@ struct br_input_skb_cb {
#define br_debug(br, format, args...) \
pr_debug("%s: " format, (br)->dev->name, ##args)
static inline struct net_bridge_dst
br_dst_read(const struct net_bridge_dst *src)
{
struct net_bridge_dst dst;
ACCESS_PRIVATE(&dst, value) =
READ_ONCE(ACCESS_PRIVATE(src, value));
return dst;
}
static inline void br_dst_write(struct net_bridge_dst *dst,
struct net_bridge_dst src)
{
WRITE_ONCE(ACCESS_PRIVATE(dst, value),
ACCESS_PRIVATE(&src, value));
}
static inline struct net_bridge_dst
br_port_to_dst(const struct net_bridge_port *p)
{
struct net_bridge_dst dst;
ACCESS_PRIVATE(&dst, value) = (unsigned long)p;
return dst;
}
static inline struct net_bridge_port *
br_dst_port(struct net_bridge_dst dst)
{
return (struct net_bridge_port *)ACCESS_PRIVATE(&dst, value);
}
/* called under bridge lock */
static inline int br_is_root_bridge(const struct net_bridge *br)
{