mirror of
https://github.com/torvalds/linux.git
synced 2026-09-24 06:24:02 +02:00
iio: chemical: sgp30: Handle IAQ thread creation failure
kthread_run() can fail and return an error pointer, but sgp_probe() stores
it and returns success, so the device is registered without its IAQ thread
and sgp_remove() later passes the error pointer to kthread_stop(). Return
the error from probe instead.
Fixes: ce51412416 ("iio: chemical: sgp30: Support Sensirion SGP30/SGPC3 sensors")
Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
This commit is contained in:
parent
8dc6d241fc
commit
1135d6875d
|
|
@ -548,6 +548,9 @@ static int sgp_probe(struct i2c_client *client)
|
|||
|
||||
data->iaq_thread = kthread_run(sgp_iaq_threadfn, data,
|
||||
"%s-iaq", data->client->name);
|
||||
if (IS_ERR(data->iaq_thread))
|
||||
return dev_err_probe(dev, PTR_ERR(data->iaq_thread),
|
||||
"failed to start IAQ thread\n");
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user