github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-12 16:18:45 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

9p: fix memory leak in v9fs_init_fs_context error path

Browse Source 
Move the assignments of fc->ops and fc->fs_private to right after the
kzalloc, before any fallible operations. Previously these were assigned
at the end of the function, after the kstrdup calls for uname and aname.
If either kstrdup failed, the error path would set fc->need_free but
leave fc->ops NULL, so put_fs_context() would never call v9fs_free_fc()
to free the allocated context and any already-duplicated strings.

Fixes: 1f3e4142c0 ("9p: convert to the new mount API")
Assisted-by: Claude:claude-opus-4-6
Signed-off-by: Sasha Levin <sashal@kernel.org>
Message-ID: <20260225135745.351984-1-sashal@kernel.org>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
This commit is contained in:
Sasha Levin 2026-02-25 08:57:45 -05:00 committed by Dominique Martinet
parent 028ef9c96e
commit 0fd76f1be2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/9p/vfs_super.c
View File

@ -312,6 +312,9 @@ static int v9fs_init_fs_context(struct fs_context *fc)
if (!ctx)
return -ENOMEM;
fc->ops = &v9fs_context_ops;
fc->fs_private = ctx;
/* initialize core options */
ctx->session_opts.afid = ~0;
ctx->session_opts.cache = CACHE_NONE;
@ -345,9 +348,6 @@ static int v9fs_init_fs_context(struct fs_context *fc)
ctx->rdma_opts.timeout = P9_RDMA_TIMEOUT;
ctx->rdma_opts.privport = false;
fc->ops = &v9fs_context_ops;
fc->fs_private = ctx;
return 0;
error:
fc->need_free = 1;