github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

firewire: core: add test for invalid length in config ROM generator

Browse Source 
Although the unit drivers and the userspace applications are allowed to
extend the system configuration ROM, they could provide invalid extension
data.

Add a KUnit test to verify that the generator handles an extension with
an invalid length.

Link: https://lore.kernel.org/r/20260901134534.2386577-12-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit is contained in:
Takashi Sakamoto 2026-09-01 22:45:32 +09:00
parent 56db07175f
commit 0eefccd9cc
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/firewire/config-rom-generator-test.c
View File

@ -306,6 +306,16 @@ static void test_config_rom_generator(struct kunit *test)
fw_core_remove_descriptor(&avc_unit_entry);
}
static void add_descriptor_with_invalid_length(struct kunit *test)
{
// Use kernel stack since they should be mutable for doubly linked-list.
struct fw_descriptor entry_with_invalid_length = {
.length = 257,
};
KUNIT_EXPECT_EQ(test, fw_core_add_descriptor(&entry_with_invalid_length), -EINVAL);
}
static const struct fw_card_driver dummy_card_driver;
static int config_rom_generator_test_init(struct kunit *test)
@ -336,6 +346,7 @@ static void config_rom_generator_test_exit(struct kunit *test)
static struct kunit_case config_rom_generator_test_cases[] = {
KUNIT_CASE_PARAM(test_config_rom_generator, generator_test_gen_params),
KUNIT_CASE(add_descriptor_with_invalid_length),
{}
};