github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-12 16:18:45 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks

Browse Source 
If ext2_get_blocks() is called with maxblocks == 0, it currently triggers
a BUG_ON(), causing a kernel panic.

While this condition implies a logic error in the caller, a filesystem
should not crash the system due to invalid arguments.

Replace the BUG_ON() with a WARN_ON_ONCE() to provide a stack trace for
debugging, and return -EINVAL to handle the error gracefully.

Signed-off-by: Milos Nikic <nikic.milos@gmail.com>
Link: https://patch.msgid.link/20260207010617.216675-1-nikic.milos@gmail.com
Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Milos Nikic 2026-02-06 17:06:17 -08:00 committed by Jan Kara
parent 6d942c874f
commit 0cf9c58bf6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/ext2/inode.c
View File

@ -638,7 +638,8 @@ static int ext2_get_blocks(struct inode *inode,
int count = 0;
ext2_fsblk_t first_block = 0;
BUG_ON(maxblocks == 0);
if (WARN_ON_ONCE(maxblocks == 0))
return -EINVAL;
depth = ext2_block_to_path(inode,iblock,offsets,&blocks_to_boundary);