From 0cad7bd51301678ad5c9aad701be29eab2ab4e7a Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Fri, 17 Jul 2026 11:50:13 +0800 Subject: [PATCH] scsi: ufs: host: Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Reviewed-by: Peter Wang Reviewed-by: Bart Van Assche Link: https://patch.msgid.link/20260717035013.563791-1-panchuang@vivo.com Signed-off-by: Martin K. Petersen --- drivers/ufs/host/ufs-mediatek.c | 4 +--- drivers/ufs/host/ufs-qcom.c | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 58701ca95edd..814c1b7343b9 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -2276,10 +2276,8 @@ static int ufs_mtk_config_mcq_irq(struct ufs_hba *hba) dev_dbg(hba->dev, "request irq %d intr %s\n", irq, ret ? "failed" : ""); - if (ret) { - dev_err(hba->dev, "Cannot request irq %d\n", ret); + if (ret) return ret; - } } host->is_mcq_intr_enabled = true; diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 0500320545c4..62396212a0a7 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -2431,8 +2431,6 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba) ret = devm_request_irq(hba->dev, qi[idx].irq, ufs_qcom_mcq_esi_handler, IRQF_SHARED, "qcom-mcq-esi", qi + idx); if (ret) { - dev_err(hba->dev, "%s: Failed to request IRQ for %d, err = %d\n", - __func__, qi[idx].irq, ret); /* Free previously allocated IRQs */ for (int j = 0; j < idx; j++) devm_free_irq(hba->dev, qi[j].irq, qi + j);