github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 05:55:44 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: pch_gbe: fix pci device refcount leak while module exiting

Browse Source 
[ Upstream commit 5619537284 ]

As comment of pci_get_domain_bus_and_slot() says, it returns
a pci device with refcount increment, when finish using it,
the caller must decrement the reference count by calling
pci_dev_put().

In pch_gbe_probe(), pci_get_domain_bus_and_slot() is called,
so in error path in probe() and remove() function, pci_dev_put()
should be called to avoid refcount leak. Compile tested only.

Fixes: 1a0bdadb4e ("net/pch_gbe: supports eg20t ptp clock")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221117135148.301014-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Yang Yingliang 2022-11-17 21:51:48 +08:00 committed by Greg Kroah-Hartman
parent 2c59ef9ab6
commit 0b553ded34
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
View File

@ -2482,6 +2482,7 @@ static void pch_gbe_remove(struct pci_dev *pdev)
unregister_netdev(netdev); unregister_netdev(netdev);
pch_gbe_phy_hw_reset(&adapter->hw); pch_gbe_phy_hw_reset(&adapter->hw);
pci_dev_put(adapter->ptp_pdev);
free_netdev(netdev); free_netdev(netdev);
} }
@ -2563,7 +2564,7 @@ static int pch_gbe_probe(struct pci_dev *pdev,
/* setup the private structure */ /* setup the private structure */
ret = pch_gbe_sw_init(adapter); ret = pch_gbe_sw_init(adapter);
if (ret) if (ret)
goto err_free_netdev; goto err_put_dev;
/* Initialize PHY */ /* Initialize PHY */
ret = pch_gbe_init_phy(adapter); ret = pch_gbe_init_phy(adapter);
@ -2621,6 +2622,8 @@ static int pch_gbe_probe(struct pci_dev *pdev,
err_free_adapter: err_free_adapter:
pch_gbe_phy_hw_reset(&adapter->hw); pch_gbe_phy_hw_reset(&adapter->hw);
err_put_dev:
pci_dev_put(adapter->ptp_pdev);
err_free_netdev: err_free_netdev:
free_netdev(netdev); free_netdev(netdev);
return ret; return ret;