github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 17:47:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

power: supply: max17042_battery: Use Current register in get_status

Browse Source 
It can take a while for AvgCurrent to adjust after (un)plugging the charger. Use the instantaneous value in order to not confuse the userspace.

While at that, don't do unit conversion of the read value. The current code was prone to overflows and we only care about the sign anyway.

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Link: https://patch.msgid.link/20260406205759.493288-3-vincent.cloutier@icloud.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
This commit is contained in:
Sebastian Krzyszkowiak 2026-04-06 16:57:50 -04:00 committed by Sebastian Reichel
parent 63f2279aa1
commit 0a733cd247
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/power/supply/max17042_battery.c
View File

@ -121,7 +121,7 @@ static int max17042_get_temperature(struct max17042_chip *chip, int *temp)
static int max17042_get_status(struct max17042_chip *chip, int *status)
{
int ret, charge_full, charge_now;
int avg_current;
int current_now;
u32 data;
ret = power_supply_am_i_supplied(chip->battery);
@ -166,14 +166,13 @@ static int max17042_get_status(struct max17042_chip *chip, int *status)
return 0;
}
ret = regmap_read(chip->regmap, MAX17042_AvgCurrent, &data);
ret = regmap_read(chip->regmap, MAX17042_Current, &data);
if (ret < 0)
return ret;
avg_current = sign_extend32(data, 15);
avg_current *= 1562500 / chip->pdata->r_sns;
current_now = sign_extend32(data, 15);
if (avg_current > 0)
if (current_now > 0)
*status = POWER_SUPPLY_STATUS_CHARGING;
else
*status = POWER_SUPPLY_STATUS_DISCHARGING;