pinctrl: s32cc: add/fix some comments

Add/fix some comments and print statements.

Reviewed-by: Linus Walleij <linusw@kernel.org>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
Signed-off-by: Khristine Andreea Barbulescu <khristineandreea.barbulescu@oss.nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
This commit is contained in:
Khristine Andreea Barbulescu 2026-06-30 14:53:58 +02:00 committed by Linus Walleij
parent 03e661e5f2
commit 0a3ac9e9d2

View File

@ -60,6 +60,12 @@ static u32 get_pin_func(u32 pinmux)
return pinmux & GENMASK(3, 0);
}
/*
* struct s32_pinctrl_mem_region - memory region for a set of SIUL2 registers
* @map: regmap used for this range
* @pin_range: the pins controlled by these registers
* @name: name of the current range
*/
struct s32_pinctrl_mem_region {
struct regmap *map;
const struct s32_pin_range *pin_range;
@ -67,7 +73,7 @@ struct s32_pinctrl_mem_region {
};
/*
* Holds pin configuration for GPIO's.
* struct gpio_pin_config - holds pin configuration for GPIO's
* @pin_id: Pin ID for this GPIO
* @config: Pin settings
* @list: Linked list entry for each gpio pin
@ -79,20 +85,22 @@ struct gpio_pin_config {
};
/*
* Pad config save/restore for power suspend/resume.
* struct s32_pinctrl_context - pad config save/restore for suspend/resume
* @pads: saved values for the pads
*/
struct s32_pinctrl_context {
unsigned int *pads;
};
/*
* struct s32_pinctrl - private driver data
* @dev: a pointer back to containing device
* @pctl: a pointer to the pinctrl device structure
* @regions: reserved memory regions with start/end pin
* @info: structure containing information about the pin
* @gpio_configs: Saved configurations for GPIO pins
* @gpiop_configs_lock: lock for the `gpio_configs` list
* @s32_pinctrl_context: Configuration saved over system sleep
* @gpio_configs: saved configurations for GPIO pins
* @gpio_configs_lock: lock for the `gpio_configs` list
* @saved_context: configuration saved over system sleep
*/
struct s32_pinctrl {
struct device *dev;
@ -970,7 +978,7 @@ int s32_pinctrl_probe(struct platform_device *pdev,
ipctl);
if (IS_ERR(ipctl->pctl))
return dev_err_probe(&pdev->dev, PTR_ERR(ipctl->pctl),
"could not register s32 pinctrl driver\n");
"Could not register s32 pinctrl driver\n");
#ifdef CONFIG_PM_SLEEP
saved_context = &ipctl->saved_context;