github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-27 00:22:00 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: libwx: Fix FW mailbox unknown command

Browse Source 
For the new SW-FW interaction, missing the error return if there is an
unknown command. It causes the driver to mistakenly believe that the
interaction is complete. This problem occurs when new driver is paired
with old firmware, which does not support the new mailbox commands.

Fixes: 2e5af6b2ae ("net: txgbe: Add basic support for new AML devices")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/64DBB705D35A0016+20250513021009.145708-4-jiawenwu@trustnetic.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Jiawen Wu 2025-05-13 10:10:09 +08:00 committed by Jakub Kicinski
parent 42efa358f0
commit 09e76365ba
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/wangxun/libwx/wx_hw.c
View File

@ -442,6 +442,12 @@ static int wx_host_interface_command_r(struct wx *wx, u32 *buffer,
goto rel_out;
}
if (hdr->cmd_or_resp.ret_status == 0x80) {
wx_err(wx, "Unknown FW command: 0x%x\n", send_cmd);
err = -EINVAL;
goto rel_out;
}
/* expect no reply from FW then return */
if (!return_data)
goto rel_out;