From 0958dcb1e5e1c036b58e629e35327a4d157c65bc Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto Date: Sun, 20 Sep 2026 17:36:57 +0900 Subject: [PATCH] firewire: cdev: use GFP_KERNEL in address handler The callback for the address handler is now guaranteed to be invoked in process context. In the cdev layer, GFP_ATOMIC is still used for memory allocation in the address handler. Use GFP_KERNEL instead. Link: https://lore.kernel.org/r/20260920083659.191855-4-o-takashi@sakamocchi.jp Signed-off-by: Takashi Sakamoto --- drivers/firewire/core-cdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/firewire/core-cdev.c b/drivers/firewire/core-cdev.c index b211396e592a..bff4560fefe9 100644 --- a/drivers/firewire/core-cdev.c +++ b/drivers/firewire/core-cdev.c @@ -785,8 +785,8 @@ static void handle_request(struct fw_card *card, struct fw_request *request, if (is_fcp) fw_request_get(request); - r = kmalloc_obj(*r, GFP_ATOMIC); - e = kmalloc_obj(*e, GFP_ATOMIC); + r = kmalloc_obj(*r); + e = kmalloc_obj(*e); if (r == NULL || e == NULL) goto failed; @@ -797,7 +797,7 @@ static void handle_request(struct fw_card *card, struct fw_request *request, r->length = length; r->resource.release = release_request; - ret = add_client_resource(handler->client, &r->resource, GFP_ATOMIC); + ret = add_client_resource(handler->client, &r->resource, GFP_KERNEL); if (ret < 0) goto failed;