github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 09:36:22 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

tools/rv: Ensure monitor name and desc are NUL-terminated

Browse Source 
ikm_fill_monitor_definition() copies monitor name and description with
strncpy(), but does not guarantee NUL termination when source strings are
equal to or longer than the destination buffers.

Clamp copies to sizeof(dst) - 1 and explicitly append '\0' for both fields
to keep them safe for later string operations.

Suggested-by: unknownbbqrx <dev@unknownbbqr.xyz>
Fixes: 6d60f89691 ("tools/rv: Add in-kernel monitor interface")
Link: https://lore.kernel.org/r/20260604120946.90302-2-gmonaco@redhat.com
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
This commit is contained in:
Gabriele Monaco 2026-06-04 14:09:45 +02:00
parent d9022172c1
commit 08904765bb
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/verification/rv/src/in_kernel.c
View File

@ -215,10 +215,11 @@ static int ikm_fill_monitor_definition(char *name, struct monitor *ikm, char *co
return -1;
}
strncpy(ikm->name, nested_name, MAX_DA_NAME_LEN);
strncpy(ikm->name, nested_name, sizeof(ikm->name) - 1);
ikm->name[sizeof(ikm->name) - 1] = '\0';
ikm->enabled = enabled;
strncpy(ikm->desc, desc, MAX_DESCRIPTION);
strncpy(ikm->desc, desc, sizeof(ikm->desc) - 1);
ikm->desc[sizeof(ikm->desc) - 1] = '\0';
free(desc);
return 0;