rtla: Add unit tests for unset in opt callbacks

Test for each opt callback that implements the unset option whether the
option sets the specified default value back correctly.

Reviewed-by: Wander Lairson Costa <wander@redhat.com>
Link: https://lore.kernel.org/r/20260629083654.1548925-2-tglozar@redhat.com
Signed-off-by: Tomas Glozar <tglozar@redhat.com>
This commit is contained in:
Tomas Glozar 2026-06-29 10:36:52 +02:00
parent deaec85cd8
commit 082b1c2c22

View File

@ -40,6 +40,30 @@ START_TEST(test_opt_llong_callback_min)
}
END_TEST
START_TEST(test_opt_llong_callback_unset)
{
long long test_value = 0;
const struct option opt = TEST_CALLBACK(&test_value, opt_llong_callback);
ck_assert_int_eq(opt_llong_callback(&opt, "1234567890", 0), 0);
ck_assert_int_eq(opt_llong_callback(&opt, NULL, 1), 0);
ck_assert_int_eq(test_value, 0);
}
END_TEST
START_TEST(test_opt_llong_callback_unset_defval)
{
long long test_value = 0;
const long long default_value = 42;
const struct option opt = RTLA_OPT_LLONG_DEFVAL('t', "test", &test_value, "test value",
"test help", &default_value);
ck_assert_int_eq(opt_llong_callback(&opt, "1234567890", 0), 0);
ck_assert_int_eq(opt_llong_callback(&opt, NULL, 1), 0);
ck_assert_int_eq(test_value, default_value);
}
END_TEST
START_TEST(test_opt_int_callback_simple)
{
int test_value = 0;
@ -90,6 +114,29 @@ START_TEST(test_opt_int_callback_non_numeric_suffix)
}
END_TEST
START_TEST(test_opt_int_callback_unset)
{
int test_value = 0;
const struct option opt = TEST_CALLBACK(&test_value, opt_int_callback);
ck_assert_int_eq(opt_int_callback(&opt, "1234567890", 0), 0);
ck_assert_int_eq(opt_int_callback(&opt, NULL, 1), 0);
ck_assert_int_eq(test_value, 0);
}
END_TEST
START_TEST(test_opt_int_callback_unset_defval)
{
int test_value = 0;
const struct option opt = RTLA_OPT_INT_DEFVAL('t', "test", &test_value, "test value",
"test help", 42);
ck_assert_int_eq(opt_int_callback(&opt, "1234567890", 0), 0);
ck_assert_int_eq(opt_int_callback(&opt, NULL, 1), 0);
ck_assert_int_eq(test_value, 42);
}
END_TEST
START_TEST(test_opt_cpus_cb)
{
struct common_params params = {0};
@ -134,6 +181,18 @@ START_TEST(test_opt_cgroup_cb_equals)
}
END_TEST
START_TEST(test_opt_cgroup_cb_unset)
{
struct common_params params = {0};
const struct option opt = TEST_CALLBACK(&params, opt_cgroup_cb);
ck_assert_int_eq(opt_cgroup_cb(&opt, "cgroup", 0), 0);
ck_assert_int_eq(opt_cgroup_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.cgroup, 0);
ck_assert_ptr_null(params.cgroup_name);
}
END_TEST
START_TEST(test_opt_duration_cb)
{
struct common_params params = {0};
@ -154,6 +213,17 @@ START_TEST(test_opt_duration_cb_invalid)
}
END_TEST
START_TEST(test_opt_duration_cb_unset)
{
struct common_params params = {0};
const struct option opt = TEST_CALLBACK(&params, opt_duration_cb);
ck_assert_int_eq(opt_duration_cb(&opt, "1m", 0), 0);
ck_assert_int_eq(opt_duration_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.duration, 0);
}
END_TEST
START_TEST(test_opt_event_cb)
{
struct trace_events *events = NULL;
@ -205,6 +275,19 @@ START_TEST(test_opt_housekeeping_cb_invalid)
}
END_TEST
START_TEST(test_opt_housekeeping_cb_unset)
{
struct common_params params = {0};
const struct option opt = TEST_CALLBACK(&params, opt_housekeeping_cb);
nr_cpus = 4;
ck_assert_int_eq(opt_housekeeping_cb(&opt, "0-3", 0), 0);
ck_assert_int_eq(opt_housekeeping_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.hk_cpus, 0);
ck_assert_int_eq(CPU_COUNT(&params.hk_cpu_set), 0);
}
END_TEST
START_TEST(test_opt_priority_cb)
{
struct common_params params = {0};
@ -226,6 +309,18 @@ START_TEST(test_opt_priority_cb_invalid)
}
END_TEST
START_TEST(test_opt_priority_cb_unset)
{
struct common_params params = {0};
const struct option opt = TEST_CALLBACK(&params, opt_priority_cb);
ck_assert_int_eq(opt_priority_cb(&opt, "f:95", 0), 0);
ck_assert_int_eq(opt_priority_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.sched_param.sched_policy, 0);
ck_assert_int_eq(params.sched_param.sched_priority, 0);
}
END_TEST
START_TEST(test_opt_trigger_cb)
{
struct trace_events *events = trace_event_alloc("sched:sched_switch");
@ -279,6 +374,20 @@ START_TEST(test_opt_osnoise_auto_cb)
}
END_TEST
START_TEST(test_opt_osnoise_auto_cb_unset)
{
struct osnoise_params params = {0};
struct osnoise_cb_data cb_data = {&params};
const struct option opt = TEST_CALLBACK(&cb_data, opt_osnoise_auto_cb);
ck_assert_int_eq(opt_osnoise_auto_cb(&opt, "10", 0), 0);
ck_assert_int_eq(opt_osnoise_auto_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.common.stop_us, 0);
ck_assert_int_eq(params.threshold, 0);
ck_assert_ptr_null(cb_data.trace_output);
}
END_TEST
START_TEST(test_opt_osnoise_period_cb)
{
unsigned long long period = 0;
@ -299,6 +408,17 @@ START_TEST(test_opt_osnoise_period_cb_invalid)
}
END_TEST
START_TEST(test_opt_osnoise_period_cb_unset)
{
unsigned long long period = 0;
const struct option opt = TEST_CALLBACK(&period, opt_osnoise_period_cb);
ck_assert_int_eq(opt_osnoise_period_cb(&opt, "1000000", 0), 0);
ck_assert_int_eq(opt_osnoise_period_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(period, 0);
}
END_TEST
START_TEST(test_opt_osnoise_runtime_cb)
{
unsigned long long runtime = 0;
@ -319,6 +439,17 @@ START_TEST(test_opt_osnoise_runtime_cb_invalid)
}
END_TEST
START_TEST(test_opt_osnoise_runtime_cb_unset)
{
unsigned long long runtime = 0;
const struct option opt = TEST_CALLBACK(&runtime, opt_osnoise_runtime_cb);
ck_assert_int_eq(opt_osnoise_runtime_cb(&opt, "900000", 0), 0);
ck_assert_int_eq(opt_osnoise_runtime_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(runtime, 0);
}
END_TEST
START_TEST(test_opt_osnoise_trace_output_cb)
{
const char *trace_output = NULL;
@ -339,6 +470,17 @@ START_TEST(test_opt_osnoise_trace_output_cb_noarg)
}
END_TEST
START_TEST(test_opt_osnoise_trace_output_cb_unset)
{
const char *trace_output = NULL;
const struct option opt = TEST_CALLBACK(&trace_output, opt_osnoise_trace_output_cb);
ck_assert_int_eq(opt_osnoise_trace_output_cb(&opt, "trace.txt", 0), 0);
ck_assert_int_eq(opt_osnoise_trace_output_cb(&opt, NULL, 1), 0);
ck_assert_ptr_null(trace_output);
}
END_TEST
START_TEST(test_opt_osnoise_on_threshold_cb)
{
struct actions actions = {0};
@ -403,6 +545,17 @@ START_TEST(test_opt_timerlat_period_cb_invalid)
}
END_TEST
START_TEST(test_opt_timerlat_period_cb_unset)
{
long long period = 0;
const struct option opt = TEST_CALLBACK(&period, opt_timerlat_period_cb);
ck_assert_int_eq(opt_timerlat_period_cb(&opt, "1000", 0), 0);
ck_assert_int_eq(opt_timerlat_period_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(period, 0);
}
END_TEST
START_TEST(test_opt_timerlat_auto_cb)
{
struct timerlat_params params = {0};
@ -417,6 +570,21 @@ START_TEST(test_opt_timerlat_auto_cb)
}
END_TEST
START_TEST(test_opt_timerlat_auto_cb_unset)
{
struct timerlat_params params = {0};
struct timerlat_cb_data cb_data = {&params};
const struct option opt = TEST_CALLBACK(&cb_data, opt_timerlat_auto_cb);
ck_assert_int_eq(opt_timerlat_auto_cb(&opt, "10", 0), 0);
ck_assert_int_eq(opt_timerlat_auto_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.common.stop_us, 0);
ck_assert_int_eq(params.common.stop_total_us, 0);
ck_assert_int_eq(params.print_stack, 0);
ck_assert_ptr_null(cb_data.trace_output);
}
END_TEST
START_TEST(test_opt_dma_latency_cb)
{
int dma_latency = 0;
@ -447,6 +615,17 @@ START_TEST(test_opt_dma_latency_cb_max)
}
END_TEST
START_TEST(test_opt_dma_latency_cb_unset)
{
int dma_latency = 0;
const struct option opt = TEST_CALLBACK(&dma_latency, opt_dma_latency_cb);
ck_assert_int_eq(opt_dma_latency_cb(&opt, "1000", 0), 0);
ck_assert_int_eq(opt_dma_latency_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(dma_latency, default_dma_latency);
}
END_TEST
START_TEST(test_opt_aa_only_cb)
{
struct timerlat_params params = {0};
@ -460,6 +639,20 @@ START_TEST(test_opt_aa_only_cb)
}
END_TEST
START_TEST(test_opt_aa_only_cb_unset)
{
struct timerlat_params params = {0};
const struct option opt = TEST_CALLBACK(&params, opt_aa_only_cb);
ck_assert_int_eq(opt_aa_only_cb(&opt, "10", 0), 0);
ck_assert_int_eq(opt_aa_only_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.common.stop_us, 0);
ck_assert_int_eq(params.common.stop_total_us, 0);
ck_assert_int_eq(params.print_stack, 0);
ck_assert_int_eq(params.common.aa_only, 0);
}
END_TEST
START_TEST(test_opt_timerlat_trace_output_cb)
{
const char *trace_output = NULL;
@ -480,6 +673,17 @@ START_TEST(test_opt_timerlat_trace_output_cb_noarg)
}
END_TEST
START_TEST(test_opt_timerlat_trace_output_cb_unset)
{
const char *trace_output = NULL;
const struct option opt = TEST_CALLBACK(&trace_output, opt_timerlat_trace_output_cb);
ck_assert_int_eq(opt_timerlat_trace_output_cb(&opt, "trace.txt", 0), 0);
ck_assert_int_eq(opt_timerlat_trace_output_cb(&opt, NULL, 1), 0);
ck_assert_ptr_null(trace_output);
}
END_TEST
START_TEST(test_opt_timerlat_on_threshold_cb)
{
struct actions actions = {0};
@ -535,6 +739,18 @@ START_TEST(test_opt_user_threads_cb)
}
END_TEST
START_TEST(test_opt_user_threads_cb_unset)
{
struct timerlat_params params = {0};
const struct option opt = TEST_CALLBACK(&params, opt_user_threads_cb);
ck_assert_int_eq(opt_user_threads_cb(&opt, NULL, 0), 0);
ck_assert_int_eq(opt_user_threads_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.common.user_workload, 0);
ck_assert_int_eq(params.common.user_data, 0);
}
END_TEST
START_TEST(test_opt_nano_cb)
{
struct timerlat_params params = {0};
@ -545,6 +761,17 @@ START_TEST(test_opt_nano_cb)
}
END_TEST
START_TEST(test_opt_nano_cb_unset)
{
struct timerlat_params params = {0};
const struct option opt = TEST_CALLBACK(&params, opt_nano_cb);
ck_assert_int_eq(opt_nano_cb(&opt, NULL, 0), 0);
ck_assert_int_eq(opt_nano_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.common.output_divisor, default_output_divisor);
}
END_TEST
START_TEST(test_opt_timerlat_align_cb)
{
struct timerlat_params params = {0};
@ -556,6 +783,18 @@ START_TEST(test_opt_timerlat_align_cb)
}
END_TEST
START_TEST(test_opt_timerlat_align_cb_unset)
{
struct timerlat_params params = {0};
const struct option opt = TEST_CALLBACK(&params, opt_timerlat_align_cb);
ck_assert_int_eq(opt_timerlat_align_cb(&opt, "500", 0), 0);
ck_assert_int_eq(opt_timerlat_align_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(params.timerlat_align, 0);
ck_assert_int_eq(params.timerlat_align_us, 0);
}
END_TEST
START_TEST(test_opt_stack_format_cb)
{
int stack_format = 0;
@ -576,6 +815,17 @@ START_TEST(test_opt_stack_format_cb_invalid)
}
END_TEST
START_TEST(test_opt_stack_format_cb_unset)
{
int stack_format = 0;
const struct option opt = TEST_CALLBACK(&stack_format, opt_stack_format_cb);
ck_assert_int_eq(opt_stack_format_cb(&opt, "full", 0), 0);
ck_assert_int_eq(opt_stack_format_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(stack_format, default_stack_format);
}
END_TEST
START_TEST(test_opt_bucket_size_cb)
{
int bucket_size = 0;
@ -606,6 +856,17 @@ START_TEST(test_opt_bucket_size_max)
}
END_TEST
START_TEST(test_opt_bucket_size_cb_unset)
{
int bucket_size = 0;
const struct option opt = TEST_CALLBACK(&bucket_size, opt_bucket_size_cb);
ck_assert_int_eq(opt_bucket_size_cb(&opt, "100", 0), 0);
ck_assert_int_eq(opt_bucket_size_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(bucket_size, default_bucket_size);
}
END_TEST
START_TEST(test_opt_entries_cb)
{
int entries = 0;
@ -636,6 +897,17 @@ START_TEST(test_opt_entries_max)
}
END_TEST
START_TEST(test_opt_entries_cb_unset)
{
int entries = 0;
const struct option opt = TEST_CALLBACK(&entries, opt_entries_cb);
ck_assert_int_eq(opt_entries_cb(&opt, "100", 0), 0);
ck_assert_int_eq(opt_entries_cb(&opt, NULL, 1), 0);
ck_assert_int_eq(entries, default_entries);
}
END_TEST
Suite *cli_opt_callback_suite(void)
{
Suite *s = suite_create("cli_opt_callback");
@ -645,23 +917,31 @@ Suite *cli_opt_callback_suite(void)
tcase_add_test(tc, test_opt_llong_callback_simple);
tcase_add_test(tc, test_opt_llong_callback_max);
tcase_add_test(tc, test_opt_llong_callback_min);
tcase_add_test(tc, test_opt_llong_callback_unset);
tcase_add_test(tc, test_opt_llong_callback_unset_defval);
tcase_add_test(tc, test_opt_int_callback_simple);
tcase_add_test(tc, test_opt_int_callback_max);
tcase_add_test(tc, test_opt_int_callback_min);
tcase_add_test(tc, test_opt_int_callback_non_numeric);
tcase_add_test(tc, test_opt_int_callback_non_numeric_suffix);
tcase_add_test(tc, test_opt_int_callback_unset);
tcase_add_test(tc, test_opt_int_callback_unset_defval);
tcase_add_test(tc, test_opt_cpus_cb);
tcase_add_exit_test(tc, test_opt_cpus_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_cgroup_cb);
tcase_add_test(tc, test_opt_cgroup_cb_equals);
tcase_add_test(tc, test_opt_cgroup_cb_unset);
tcase_add_test(tc, test_opt_duration_cb);
tcase_add_test(tc, test_opt_duration_cb_unset);
tcase_add_exit_test(tc, test_opt_duration_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_event_cb);
tcase_add_test(tc, test_opt_event_cb_multiple);
tcase_add_test(tc, test_opt_housekeeping_cb);
tcase_add_exit_test(tc, test_opt_housekeeping_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_housekeeping_cb_unset);
tcase_add_test(tc, test_opt_priority_cb);
tcase_add_exit_test(tc, test_opt_priority_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_priority_cb_unset);
tcase_add_test(tc, test_opt_trigger_cb);
tcase_add_exit_test(tc, test_opt_trigger_cb_no_event, EXIT_FAILURE);
tcase_add_test(tc, test_opt_filter_cb);
@ -670,12 +950,16 @@ Suite *cli_opt_callback_suite(void)
tc = tcase_create("osnoise");
tcase_add_test(tc, test_opt_osnoise_auto_cb);
tcase_add_test(tc, test_opt_osnoise_auto_cb_unset);
tcase_add_test(tc, test_opt_osnoise_period_cb);
tcase_add_test(tc, test_opt_osnoise_period_cb_unset);
tcase_add_exit_test(tc, test_opt_osnoise_period_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_osnoise_runtime_cb);
tcase_add_exit_test(tc, test_opt_osnoise_runtime_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_osnoise_runtime_cb_unset);
tcase_add_test(tc, test_opt_osnoise_trace_output_cb);
tcase_add_test(tc, test_opt_osnoise_trace_output_cb_noarg);
tcase_add_test(tc, test_opt_osnoise_trace_output_cb_unset);
tcase_add_test(tc, test_opt_osnoise_on_threshold_cb);
tcase_add_exit_test(tc, test_opt_osnoise_on_threshold_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_osnoise_on_end_cb);
@ -685,31 +969,42 @@ Suite *cli_opt_callback_suite(void)
tc = tcase_create("timerlat");
tcase_add_test(tc, test_opt_timerlat_period_cb);
tcase_add_exit_test(tc, test_opt_timerlat_period_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_timerlat_period_cb_unset);
tcase_add_test(tc, test_opt_timerlat_auto_cb);
tcase_add_test(tc, test_opt_timerlat_auto_cb_unset);
tcase_add_test(tc, test_opt_dma_latency_cb);
tcase_add_exit_test(tc, test_opt_dma_latency_cb_min, EXIT_FAILURE);
tcase_add_exit_test(tc, test_opt_dma_latency_cb_max, EXIT_FAILURE);
tcase_add_test(tc, test_opt_dma_latency_cb_unset);
tcase_add_test(tc, test_opt_aa_only_cb);
tcase_add_test(tc, test_opt_aa_only_cb_unset);
tcase_add_test(tc, test_opt_timerlat_trace_output_cb);
tcase_add_test(tc, test_opt_timerlat_trace_output_cb_noarg);
tcase_add_test(tc, test_opt_timerlat_trace_output_cb_unset);
tcase_add_test(tc, test_opt_timerlat_on_threshold_cb);
tcase_add_exit_test(tc, test_opt_timerlat_on_threshold_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_timerlat_on_end_cb);
tcase_add_exit_test(tc, test_opt_timerlat_on_end_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_user_threads_cb);
tcase_add_test(tc, test_opt_user_threads_cb_unset);
tcase_add_test(tc, test_opt_nano_cb);
tcase_add_test(tc, test_opt_nano_cb_unset);
tcase_add_test(tc, test_opt_stack_format_cb);
tcase_add_exit_test(tc, test_opt_stack_format_cb_invalid, EXIT_FAILURE);
tcase_add_test(tc, test_opt_stack_format_cb_unset);
tcase_add_test(tc, test_opt_timerlat_align_cb);
tcase_add_test(tc, test_opt_timerlat_align_cb_unset);
suite_add_tcase(s, tc);
tc = tcase_create("histogram");
tcase_add_test(tc, test_opt_bucket_size_cb);
tcase_add_exit_test(tc, test_opt_bucket_size_min, EXIT_FAILURE);
tcase_add_exit_test(tc, test_opt_bucket_size_max, EXIT_FAILURE);
tcase_add_test(tc, test_opt_bucket_size_cb_unset);
tcase_add_test(tc, test_opt_entries_cb);
tcase_add_exit_test(tc, test_opt_entries_min, EXIT_FAILURE);
tcase_add_exit_test(tc, test_opt_entries_max, EXIT_FAILURE);
tcase_add_test(tc, test_opt_entries_cb_unset);
suite_add_tcase(s, tc);
return s;