github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-08 14:42:37 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

can: mcba_usb: mcba_usb_start_xmit(): fix double dev_kfree_skb in error path

Browse Source 
commit 04c9b00ba8 upstream.

There is no need to call dev_kfree_skb() when usb_submit_urb() fails
because can_put_echo_skb() deletes original skb and
can_free_echo_skb() deletes the cloned skb.

Fixes: 51f3baad7d ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
Link: https://lore.kernel.org/all/20220311080208.45047-1-hbh25y@gmail.com
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Hangyu Hua 2022-03-11 16:02:08 +08:00 committed by Greg Kroah-Hartman
parent 1ac49c8fd4
commit 0801a51d79
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/net/can/usb/mcba_usb.c
View File

@ -368,7 +368,6 @@ static netdev_tx_t mcba_usb_start_xmit(struct sk_buff *skb,
xmit_failed: xmit_failed:
can_free_echo_skb(priv->netdev, ctx->ndx); can_free_echo_skb(priv->netdev, ctx->ndx);
mcba_usb_free_ctx(ctx); mcba_usb_free_ctx(ctx);
dev_kfree_skb(skb);
stats->tx_dropped++; stats->tx_dropped++;
return NETDEV_TX_OK; return NETDEV_TX_OK;