github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-30 10:04:04 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

scsi: BusLogic: Call scsi_done() directly

Browse Source 
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-13-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bart Van Assche 2021-10-07 13:28:07 -07:00 committed by Martin K. Petersen
parent 656f26ade0
commit 0800a26aaa
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/scsi/BusLogic.c
View File

@ -2624,7 +2624,7 @@ static void blogic_process_ccbs(struct blogic_adapter *adapter)
command->reset_chain; command->reset_chain;
command->reset_chain = NULL; command->reset_chain = NULL;
command->result = DID_RESET << 16; command->result = DID_RESET << 16;
command->scsi_done(command); scsi_done(command);
command = nxt_cmd; command = nxt_cmd;
} }
#endif #endif
@ -2641,7 +2641,7 @@ static void blogic_process_ccbs(struct blogic_adapter *adapter)
blogic_dealloc_ccb(ccb, 1); blogic_dealloc_ccb(ccb, 1);
adapter->active_cmds[tgt_id]--; adapter->active_cmds[tgt_id]--;
command->result = DID_RESET << 16; command->result = DID_RESET << 16;
command->scsi_done(command); scsi_done(command);
} }
adapter->bdr_pend[tgt_id] = NULL; adapter->bdr_pend[tgt_id] = NULL;
} else { } else {
@ -2713,7 +2713,7 @@ static void blogic_process_ccbs(struct blogic_adapter *adapter)
/* /*
Call the SCSI Command Completion Routine. Call the SCSI Command Completion Routine.
*/ */
command->scsi_done(command); scsi_done(command);
} }
} }
adapter->processing_ccbs = false; adapter->processing_ccbs = false;
@ -3038,7 +3038,6 @@ static int blogic_qcmd_lck(struct scsi_cmnd *command,
return SCSI_MLQUEUE_HOST_BUSY; return SCSI_MLQUEUE_HOST_BUSY;
} }
ccb->sensedata = sense_buf; ccb->sensedata = sense_buf;
command->scsi_done = comp_cb;
if (blogic_multimaster_type(adapter)) { if (blogic_multimaster_type(adapter)) {
/* /*
Place the CCB in an Outgoing Mailbox. The higher levels Place the CCB in an Outgoing Mailbox. The higher levels
@ -3060,7 +3059,7 @@ static int blogic_qcmd_lck(struct scsi_cmnd *command,
blogic_warn("Still unable to write Outgoing Mailbox - Host Adapter Dead?\n", adapter); blogic_warn("Still unable to write Outgoing Mailbox - Host Adapter Dead?\n", adapter);
blogic_dealloc_ccb(ccb, 1); blogic_dealloc_ccb(ccb, 1);
command->result = DID_ERROR << 16; command->result = DID_ERROR << 16;
command->scsi_done(command); scsi_done(command);
} }
} }
} else { } else {