github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-06 21:45:45 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

usb: gadget: tegra-xudc: Do not program SPARAM

Browse Source 
[ Upstream commit 62fb61580e ]

According to the Tegra Technical Reference Manual, SPARAM
is a read-only register and should not be programmed in
the driver.

The change removes the wrong SPARAM usage.

Signed-off-by: Wayne Chang <waynec@nvidia.com>
Link: https://lore.kernel.org/r/20220107090443.149021-1-waynec@nvidia.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Wayne Chang 2022-01-07 17:04:43 +08:00 committed by Greg Kroah-Hartman
parent 927beb05aa
commit 07971b818e
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/usb/gadget/udc/tegra-xudc.c
View File

@ -32,9 +32,6 @@
#include <linux/workqueue.h> #include <linux/workqueue.h>
/* XUSB_DEV registers */ /* XUSB_DEV registers */
#define SPARAM 0x000
#define SPARAM_ERSTMAX_MASK GENMASK(20, 16)
#define SPARAM_ERSTMAX(x) (((x) << 16) & SPARAM_ERSTMAX_MASK)
#define DB 0x004 #define DB 0x004
#define DB_TARGET_MASK GENMASK(15, 8) #define DB_TARGET_MASK GENMASK(15, 8)
#define DB_TARGET(x) (((x) << 8) & DB_TARGET_MASK) #define DB_TARGET(x) (((x) << 8) & DB_TARGET_MASK)
@ -3295,11 +3292,6 @@ static void tegra_xudc_init_event_ring(struct tegra_xudc *xudc)
unsigned int i; unsigned int i;
u32 val; u32 val;
val = xudc_readl(xudc, SPARAM);
val &= ~(SPARAM_ERSTMAX_MASK);
val |= SPARAM_ERSTMAX(XUDC_NR_EVENT_RINGS);
xudc_writel(xudc, val, SPARAM);
for (i = 0; i < ARRAY_SIZE(xudc->event_ring); i++) { for (i = 0; i < ARRAY_SIZE(xudc->event_ring); i++) {
memset(xudc->event_ring[i], 0, XUDC_EVENT_RING_SIZE * memset(xudc->event_ring[i], 0, XUDC_EVENT_RING_SIZE *
sizeof(*xudc->event_ring[i])); sizeof(*xudc->event_ring[i]));