From 05fe748456ea1c276c666f462f1b41882e0179ef Mon Sep 17 00:00:00 2001 From: Nicolai Buchwitz Date: Fri, 2 Oct 2026 11:42:08 +0200 Subject: [PATCH] net: reject ops-locked drivers without ndo_set_rx_mode_async ndo_set_rx_mode cannot sleep and runs with netif_addr_lock_bh held, so an ops-locked driver cannot take the instance lock from it. ndo_set_rx_mode_async is the replacement and runs in process context. Registration has only warned about this since v7.1, long enough to find the offenders. Make it an error. Suggested-by: Jakub Kicinski Signed-off-by: Nicolai Buchwitz Link: https://patch.msgid.link/20261002094211.2350702-3-nb@tipi-net.de Signed-off-by: Jakub Kicinski --- net/core/dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index a44bcfc29d54..ca7f4844cc40 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -11463,8 +11463,10 @@ static int netdev_check_ops(struct net_device *dev) } if (netdev_need_ops_lock(dev) && ops->ndo_set_rx_mode && - !ops->ndo_set_rx_mode_async) + !ops->ndo_set_rx_mode_async) { netdev_WARN(dev, "ops-locked drivers should use ndo_set_rx_mode_async\n"); + return -EINVAL; + } return 0; }