github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-27 16:44:58 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: airoha: Fix a copy and paste bug in probe()

Browse Source 
This code has a copy and paste bug where it accidentally checks "if (err)"
instead of checking if "xsi_rsts" is NULL.  Also, as a free bonus, I
changed the allocation from kzalloc() to  kcalloc() which is a kernel
hardening measure to protect against integer overflows.

Fixes: 5863b4e065 ("net: airoha: Add airoha_eth_soc_data struct")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/aPtht6y5DRokn9zv@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Dan Carpenter 2025-10-24 14:23:35 +03:00 committed by Jakub Kicinski
parent bbfa5e7c8d
commit 05e090620b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/airoha/airoha_eth.c
View File

@ -2985,11 +2985,11 @@ static int airoha_probe(struct platform_device *pdev)
return err;
}
xsi_rsts = devm_kzalloc(eth->dev,
eth->soc->num_xsi_rsts * sizeof(*xsi_rsts),
xsi_rsts = devm_kcalloc(eth->dev,
eth->soc->num_xsi_rsts, sizeof(*xsi_rsts),
GFP_KERNEL);
if (err)
return err;
if (!xsi_rsts)
return -ENOMEM;
eth->xsi_rsts = xsi_rsts;
for (i = 0; i < eth->soc->num_xsi_rsts; i++)