From 64172fa3088d20eb0dc91a8a45ff29fae63c3936 Mon Sep 17 00:00:00 2001 From: Nathan Chancellor Date: Tue, 26 May 2026 14:53:12 -0700 Subject: [PATCH 1/3] ASoC: SDCA: Make CONFIG_SND_SOC_SDCA a user selectable symbol Currently, CONFIG_SND_SOC_SDCA is a hidden Kconfig symbol, so it must be selected by a user selectable symbol to be enabled. However, it may not be possible for configurations to select this symbol without running into a recursive dependency issue: error: recursive dependency detected! symbol SOUNDWIRE depends on SND_SOC_SDCA_OPTIONAL symbol SND_SOC_SDCA_OPTIONAL default value contains SND_SOC_SDCA symbol SND_SOC_SDCA is selected by SND_SOC_ES9356 symbol SND_SOC_ES9356 depends on SOUNDWIRE Turn CONFIG_SND_SOC_SDCA into a user selectable symbol so that drivers can depend on it and allow the user to enable it explicitly. Signed-off-by: Nathan Chancellor Link: https://patch.msgid.link/20260526-es9356-dep-fixes-v1-1-39ac16f43d54@kernel.org Signed-off-by: Mark Brown --- sound/soc/sdca/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sdca/Kconfig b/sound/soc/sdca/Kconfig index 87ab2895096c..4c0dcb9ff3b9 100644 --- a/sound/soc/sdca/Kconfig +++ b/sound/soc/sdca/Kconfig @@ -2,7 +2,7 @@ menu "SoundWire (SDCA)" config SND_SOC_SDCA - tristate + tristate "SDCA core support" depends on ACPI select AUXILIARY_BUS help From bf6dfd0e6c9123658fbf3217779ad7396960f2ea Mon Sep 17 00:00:00 2001 From: Nathan Chancellor Date: Tue, 26 May 2026 14:53:13 -0700 Subject: [PATCH 2/3] ASoC: codecs: Adjust indentation in CONFIG_SND_SOC_ES9356 definition The indentation of CONFIG_SND_SOC_ES9356 uses spaces, instead of the Kconfig standard using tabs. Adjust it. Signed-off-by: Nathan Chancellor Link: https://patch.msgid.link/20260526-es9356-dep-fixes-v1-2-39ac16f43d54@kernel.org Signed-off-by: Mark Brown --- sound/soc/codecs/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index a7c61f7c7f4c..9b6c7c7533bb 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1301,10 +1301,10 @@ config SND_SOC_ES8389 depends on I2C config SND_SOC_ES9356 - tristate "Everest Semi ES9356 CODEC SDW" - depends on SOUNDWIRE - select REGMAP_SOUNDWIRE - select REGMAP_SOUNDWIRE_MBQ + tristate "Everest Semi ES9356 CODEC SDW" + depends on SOUNDWIRE + select REGMAP_SOUNDWIRE + select REGMAP_SOUNDWIRE_MBQ config SND_SOC_FRAMER tristate "Framer codec" From 74baa9df1d3d590e4aaab3ac78cba5bbf826d8b6 Mon Sep 17 00:00:00 2001 From: Nathan Chancellor Date: Tue, 26 May 2026 14:53:14 -0700 Subject: [PATCH 3/3] ASoC: es9356-sdca: Depend on CONFIG_SND_SOC_SDCA When building without CONFIG_SND_SOC_SDCA, there is an error at link time when building the es9356-sdca driver: ERROR: modpost: "sdca_asoc_q78_get_volsw" [sound/soc/codecs/snd-soc-es9356.ko] undefined! ERROR: modpost: "sdca_asoc_q78_put_volsw" [sound/soc/codecs/snd-soc-es9356.ko] undefined! Add an explicit dependency on CONFIG_SND_SOC_SDCA to ensure these symbols are always present when building the driver. Fixes: 5d9cb740cd38 ("ASoC: es9356-sdca: Add ES9356 SDCA driver") Signed-off-by: Nathan Chancellor Link: https://patch.msgid.link/20260526-es9356-dep-fixes-v1-3-39ac16f43d54@kernel.org Signed-off-by: Mark Brown --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 9b6c7c7533bb..a7e3ee80485a 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1302,6 +1302,7 @@ config SND_SOC_ES8389 config SND_SOC_ES9356 tristate "Everest Semi ES9356 CODEC SDW" + depends on SND_SOC_SDCA depends on SOUNDWIRE select REGMAP_SOUNDWIRE select REGMAP_SOUNDWIRE_MBQ