From 00efe8a685658deb7033d68fcdbf0a7e6796352e Mon Sep 17 00:00:00 2001 From: Hsieh Hung-En Date: Thu, 1 Oct 2026 08:49:40 +0800 Subject: [PATCH] drm/panel: ronbo-rb070d30: Ignore DCS errors in disable() If rb070d30_panel_disable() returns an error, drm_panel_disable() skips clearing panel->enabled. unprepare() still powers the panel off, but the next drm_panel_enable() sees the panel as already enabled and does nothing, so the panel stays dark. Always return 0 from disable(). A failed ENTER_SLEEP_MODE is still logged by mipi_dsi_dcs_enter_sleep_mode_multi(). Suggested-by: Douglas Anderson Signed-off-by: Hsieh Hung-En Reviewed-by: Neil Armstrong Signed-off-by: Neil Armstrong Link: https://patch.msgid.link/20261001004940.110776-1-hungen3108@gmail.com --- drivers/gpu/drm/panel/panel-ronbo-rb070d30.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c index ebe6352db6c1..9adf97aba5d3 100644 --- a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c +++ b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c @@ -87,7 +87,13 @@ static int rb070d30_panel_disable(struct drm_panel *panel) struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); - return dsi_ctx.accum_err; + + /* + * Returning an error would leave panel->enabled set, causing the + * next enable to be skipped even after unprepare powers off the panel. + * The helper above already logs any command failure. + */ + return 0; } /* Default timings */