Simplify the transfer to use the existing function (which also adds logs)

This commit is contained in:
Rosemary Orchard 2022-04-18 10:55:13 +01:00
parent 277dbc47c0
commit e2e2cb6d93

View File

@ -1007,11 +1007,11 @@ class StockService extends BaseService
]); ]);
$logRow->save(); $logRow->save();
$update = [ $stockEntry->update([
'open' => 1, 'open' => 1,
'opened_date' => date('Y-m-d'), 'opened_date' => date('Y-m-d'),
'best_before_date' => $newBestBeforeDate 'best_before_date' => $newBestBeforeDate
]; ]);
$amount -= $stockEntry->amount; $amount -= $stockEntry->amount;
} }
@ -1048,20 +1048,21 @@ class StockService extends BaseService
]); ]);
$logRow->save(); $logRow->save();
$update = [ $stockEntry->update([
'amount' => $amount, 'amount' => $amount,
'open' => 1, 'open' => 1,
'opened_date' => date('Y-m-d'), 'opened_date' => date('Y-m-d'),
'best_before_date' => $newBestBeforeDate 'best_before_date' => $newBestBeforeDate
]; ]);
$amount = 0; $amount = 0;
} }
if ($product->move_on_open) { if ($product->move_on_open) {
$update['location_id'] = $product->default_consume_location_id ?? $stockEntry->location_id; $locationIdTo = $product->default_consume_location_id;
if ($locationIdTo) {
$this->TransferProduct($stockEntry->product_id, $amount, $stockEntry->location_id, $locationIdTo, $stockEntry->stock_id, $transactionId);
}
} }
$stockEntry->update($update);
} }
return $transactionId; return $transactionId;