Review

controllers/SystemApiController.php

@@ -44,13 +44,28 @@ class SystemApiController extends BaseApiController
 	}
 
 	public function GetSystemTime(\Psr\Http\Message\ServerRequestInterface $request, \Psr\Http\Message\ResponseInterface $response, array $args)
+	{
+		try
 		{
 			$offset = 0;
 			$params = $request->getQueryParams();
 			if (isset($params['offset']))
+			{
+				if (!filter_var($params['offset'], FILTER_VALIDATE_INT))
+				{
+					throw new \Exception('Query parameter "offset" is not a valid integer');
+				}
+
 				$offset = $params['offset'];
+			}
+
 			return $this->ApiResponse($response, $this->getApplicationService()->GetSystemTime($offset));
 		}
+		catch (\Exception $ex)
+		{
+			return $this->GenericErrorResponse($response, $ex->getMessage());
+		}
+	}
 
 	public function LogMissingLocalization(\Psr\Http\Message\ServerRequestInterface $request, \Psr\Http\Message\ResponseInterface $response, array $args)
 	{

services/ApplicationService.php

@@ -76,29 +76,32 @@ class ApplicationService extends BaseService
 		];
 	}
 
-	private static function convertToUtc(int $timestamp):string
+	private static function convertToUtc(int $timestamp): string
 	{
 		$dt = new \DateTime('now', new \DateTimeZone('UTC'));
 		$dt->setTimestamp($timestamp);
 		return $dt->format('Y-m-d H:i:s');
 	}
 
-
+	private static function getSqliteLocaltime(int $offset): string
-	private static function getSqliteLocaltime(int $offset):string
 	{
 		$pdo = new \PDO('sqlite::memory:');
 		if ($offset > 0)
+		{
 			return $pdo->query('SELECT datetime(\'now\', \'+' . $offset . ' seconds\', \'localtime\');')->fetch()[0];
+		}
 		else
+		{
 			return $pdo->query('SELECT datetime(\'now\', \'' . $offset . ' seconds\', \'localtime\');')->fetch()[0];
 		}
+	}
 
 	/**
 	 * Returns the response for the API call /system/time
 	 * @param int $offset an offset in seconds to be applied
 	 * @return array
 	 */
-	public function GetSystemTime(int $offset = 0):array
+	public function GetSystemTime(int $offset = 0): array
 	{
 		$timestamp = time() + $offset;
 		$timeLocal = date('Y-m-d H:i:s', $timestamp);